[ 
https://issues.apache.org/jira/browse/SOLR-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333275#comment-17333275
 ] 

Cassandra Targett commented on SOLR-15217:
------------------------------------------

I noticed in the changes for the latest commit here that the update to 
{{major-changes-in-solr-9.adoc}} seem to be incorrect. It says:

{noformat}
The allow-list defining allowed URLs for the `shards` parameter is not in the 
`shardHandler` configuration anymore. It is defined by the `allowUrls` 
top-level property of the `solrconfig.xml` file. For more information, see 
<<format-of-solr-xml.adoc#_allow_urls, Format of solr.allowUrls>> documentation.
{noformat}

It says the change is to put the param in solrconfig.xml, then links to the 
solr.xml documentation.

I also find it curious that there was no patch nor a PR for this? It's a rather 
big change - 45 files. I thought we were agreed as a project that we only 
skipped review for trivial/minor changes?

> use shardsWhitelist in ReplicationHandler
> -----------------------------------------
>
>                 Key: SOLR-15217
>                 URL: https://issues.apache.org/jira/browse/SOLR-15217
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: Bruno Roustant
>            Priority: Major
>             Fix For: 8.9, 8.8.2
>
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> The {{shardsWhitelist}} is defined on shardHandlerFactory element in 
> solr.xml.  We should rename it so something like "shardsAllowList".  And we 
> could use it in more places.
> https://solr.apache.org/guide/8_7/distributed-requests.html#configuring-the-shardhandlerfactory



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to