jward-bw commented on a change in pull request #265:
URL: https://github.com/apache/solr-operator/pull/265#discussion_r622292273
##########
File path: controllers/util/solr_util.go
##########
@@ -214,16 +214,20 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
},
}
} else {
- emptyDirVolume := corev1.Volume{
- Name: solrDataVolumeName,
- VolumeSource: corev1.VolumeSource{
- EmptyDir: &corev1.EmptyDirVolumeSource{},
- },
+ ephemeralVolume := corev1.Volume{
+ Name: solrDataVolumeName,
+ VolumeSource: corev1.VolumeSource{},
}
if solrCloud.Spec.StorageOptions.EphemeralStorage != nil {
Review comment:
I might have misunderstood what you meant, but I've added a check for if
EmptyDir is nil, and a corresponding test. There was already a test for if
EphemeralStorage is empty though (if that's what you meant?):
https://github.com/apache/solr-operator/blob/c78b2b80ab097cb7f1b573f4fca8903ba7f63eb9/controllers/solrcloud_controller_storage_test.go#L240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
