[
https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339212#comment-17339212
]
Chris M. Hostetter commented on SOLR-15335:
-------------------------------------------
I haven't tried it but based on a quick read +1 ... not really familiar with
network aliases but if it plays nicer with buildkit then sure ... and it's
definitely a plus that we don't have to explicitly start/stop a network with a
unique name.
bq. If you are interested in comments on the contents of the Dockerfile, I'll
list them here. If you mainly want to get the build setup and optimize later,
that's fine.
I was really trying to focus on committing the templating (and template
testing) and worry about "improvements" to the dockerfile templates in a
subsequent issue -- but if there is anything in the templates that you think
shouldn't be committed at all w/o changing then by all means let's fix it
> templated (header + body) approach for building Dockerfile.local +
> Dockerfile.official w/common guts
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-15335
> URL: https://issues.apache.org/jira/browse/SOLR-15335
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15335-no-custom-network.patch, SOLR-15335.patch,
> SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch,
> SOLR-15335.patch
>
>
> Goals:
> * "generate" a Dockerfile.official at release time that will satisfy the
> process/tooling of docker-library for 'official' docker images
> ** use a templated approach to fill in things like version, sha512, and GPG
> fingerprint
> * ensure that the generated Dockerfile.official and the Dockerfile.local
> included in solr.tgz are identical in terms of the "operational" aspects of a
> Solr docker image (ie: what the disk layout looks like, and how it runs)
> ** they should only differ in how they get the contents of a solr.tgz into
> the docker image (and how much they trust it before unpacking it)
> * minimize the amount of overhead needed to make changes that exist in in
> both dockerfiles
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
