[
https://issues.apache.org/jira/browse/SOLR-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340464#comment-17340464
]
David Smiley commented on SOLR-15156:
-------------------------------------
I overlooked that childFilter existed prior to 8.0 and was not escaped then.
It started escaping in 8.0. A user reported difficulty when upgrading from
Solr 6 --
https://lists.apache.org/thread.html/r7f7ca6cacd390882443dcbf2cd6fe6d7b0c5fc6e28c2d431823cf40a%40%3Cusers.solr.apache.org%3E
So I think I should apply this change to 8.9 and add an entry to the upgrade
notes for those upgrading from earlier 8.x versions. WDYT [~epugh]?
> child transformer's childFilter shouldn't do escaping
> -----------------------------------------------------
>
> Key: SOLR-15156
> URL: https://issues.apache.org/jira/browse/SOLR-15156
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Fix For: main (9.0)
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{child}} doc transformer's {{childFilter}} supports both some special
> path syntax and a simple field:value query with built-in escaping, or some
> other query so long as it doesn't contain a colon. I think there should not
> have been escaping here in the first place, thus letting you express whatever
> interesting query you want like we do in most other places in Solr. Simple.
> It may mean the user has to escape characters like '/' but that's normal. In
> a Java String that has an embedded local-params for the child doc
> transformer, that winds up being four back-slashes. So be it. It may seem
> like we're trying to do the user a favor by escaping what we see but I think
> it's actually more confusing to reason about because it's inconsistent, and
> it's limiting by getting in the way of more interesting queries. Besides,
> there are other ways of constructing the query syntax that results in zero
> escaping like {{childFilter='\{!field f=_nest_path_}/toppings'}} So that's
> longer but no escaping at least. Up to the user's prerogative.
> This will break existing users who depend on the escaping, and so warrants
> being done in a major release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
