suryakant261 edited a comment on pull request #58:
URL: https://github.com/apache/solr/pull/58#issuecomment-841449005


   > Hi @suryakant261, could I ask you to do the following please:
   > 
   > * revisit the `validate` change to ensure all of the tree continues to be 
validated
   > * run the `solr/contrib/ltr` tests locally to check they pass
   > 
   > When you get a chance, no rush, we all contribute here as and when time 
permits. Thanks!
   
   Hi @cpoerschke 
   1. Done using iterative preorder traversal.
   2. All the test cases passing in the local run now. (Wasn't aware that these 
are not part of Pull requests build, should we enable it?)
   
![image](https://user-images.githubusercontent.com/12580992/118318088-86c69000-b516-11eb-835f-9021a6cbac89.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to