dsmiley commented on a change in pull request #115:
URL: https://github.com/apache/solr/pull/115#discussion_r633562617



##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java
##########
@@ -549,7 +546,9 @@ public InputStream getStream() throws IOException {
     public SolrParams parseParamsAndFillStreams( 
         final HttpServletRequest req, ArrayList<ContentStream> streams ) 
throws Exception
     {
-      streams.add( new HttpRequestContentStream( req ) );
+      if (!req.getMethod().equals("GET")) { // or other conditions? Check 
headers?
+        streams.add(new HttpRequestContentStream(req));
+      }

Review comment:
       I should enhance this condition to look for `Content-Length` or 
`Transfer-Encoding` headers, which the HTTP RFC says is how you know if there 
is a message body.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to