dsmiley commented on pull request #134: URL: https://github.com/apache/solr/pull/134#issuecomment-844396343
I tried to avoid the PushBackInputStream thing but in the end I found it necessary. At least it will rarely be used, I think. I did ensure this code actually works by temporarily removing the short-circuit conditions and then running the test. I could add a method==GET check as well since I think it's fundamentally invalid? FYI this is called by StandardRequestParsers.parseParamsAndFillStreams. I don't like the way that method makes assumptions about paths for /schema and v2 API which seem to be concerns that should be elsewhere like HttpSolrCall (if necessary) or perhaps give handlers the opportunity to get involved in this (if necessary). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
