cpoerschke commented on pull request #123: URL: https://github.com/apache/solr/pull/123#issuecomment-846994896
Hi @tomglk! > I am currently debugging some ltr stuff and stumbled upon this: ... Why don't we try to parse the string value as number? We do that for docValues, but not for stored fields. Ah, we seem to have both stumbled upon the same question though perhaps via different routes?! I was trying to extend `TestFieldValueFeature.testThatStringValuesAreCorrectlyParsed` to also cover non-docValues field _and_ to ensure behavioural consistency between dv and non-dv fields i.e. docValues and stored fields. My conclusion was that for back compat reasons the docValues would need to match stored fields behaviour -- _I will add a commit with proposed changes shortly_ -- and that what looks like a "string" value in the implementation is for "boolean" values only really i.e. F/0 and T/1 and when number values are required a number field type would/should be used instead. _And advance apologies, the commit has multiple things in one commit though I've tried to at least describe in the commit message details what is in it. Looking forward to your thoughts on it._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
