thelabdude commented on pull request #42: URL: https://github.com/apache/solr/pull/42#issuecomment-848845362
Thanks for taking a look @HoustonPutman ... I addressed most of your concerns but there's some nuance around a few of your requests: > I would like to be able to populate the example document with a document that exists. Maybe a button in the query results. I haven't implemented this yet. The query results only include sample documents already, so maybe you want to revise the sample documents in the paste text area? I think that's a valid thing to do and will think about this some more. My only concern would be adding another option that may complicate the experience. Can you elaborate on the user experience you want here? > Do we recommend the use of useDocValuesAsStored instead of stored? I'm not sure about whether that is a recommendation? Seems reasonable to me that if you're already using DocValues, then `useDocValuesAsStored` seems more efficient from a storage perspective (if you store and use doc values, then seems like you're doing double storage), but maybe there is some performance hit for doing this? I can certainly turn that off if we don't like defaulting to stored=false and useDocValuesAsStored=true. > When you analyze the fields it sometimes brings up a question about language and some options. Not clear that this is talking about the entire schema. Would be better to highlight the configName in the menu. There are some gremlins in that jstree we're using where the selected node doesn't always show as selected in the tree. I've tried to improve this with my latest commit and seems to be rendering correctly. When the root node is selected, you see the panel with languages and options. Those apply to the entire schema. I added the schema name to that panel to help make this clear. > In the future it would be nice to have information on each of the options. Not sure what the best way to go about this is though. I think some of the options are pretty confusing and need supporting documentation, so have deferred to the ref guide via the help icon links vs. adding more docs directly in the Schema Designer UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
