dsmiley commented on a change in pull request #115: URL: https://github.com/apache/solr/pull/115#discussion_r639923095
########## File path: solr/core/src/java/org/apache/solr/api/V2HttpCall.java ########## @@ -360,6 +366,80 @@ protected void execute(SolrQueryResponse rsp) { SolrCore.postDecorateResponse(handler, solrReq, rsp); } + @Override + protected void populateTracingSpan(Span span) { + // Set db.instance + String coreOrColName = this.origCorename; + if (coreOrColName == null) { + Map<String, String> pathTemplateValues = getUrlParts(); // == solrReq.getPathTemplateValues() + coreOrColName = pathTemplateValues.get("collection"); + if (coreOrColName == null) { + coreOrColName = pathTemplateValues.get("core"); + } + } + if (coreOrColName != null) { + span.setTag(Tags.DB_INSTANCE, coreOrColName); + } + + // Get the templatize-ed path + String path; + if (api instanceof AnnotatedApi) { + // ideal scenario; eventually everything might be AnnotatedApi? + path = ((AnnotatedApi) api).getEndPoint().path()[0]; // consider first to be primary + } else { + path = computeEndpointPath(); + // TODO consider getValidators, looking for command & path? + } + + String verb = req.getMethod().toLowerCase(Locale.ROOT); Review comment: BTW when I said > the relative cost of this compared to the limited cases where this is activated. I not only meant opt-in to tracing but in the big picture of all that goes on to field a request into Solr to actually do something. Lowercasing a string is inconsequential. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org