Mike Drob created SOLR-15462:
--------------------------------
Summary: Dubious code in DistribPackageStore::refresh
Key: SOLR-15462
URL: https://issues.apache.org/jira/browse/SOLR-15462
Project: Solr
Issue Type: Task
Security Level: Public (Default Security Level. Issues are Public)
Components: Package Manager
Reporter: Mike Drob
The code in DistribPackageStore::refresh is slightly dubious. Discovered while
working on SOLR-15385...
{code:java}
@SuppressWarnings({"rawtypes"})
List l = null;
l =
coreContainer.getZkController().getZkClient().getChildren(ZK_PACKAGESTORE +
path, null, true);
@SuppressWarnings({"rawtypes"})
List myFiles = list(path, s -> true);
for (Object f : l) {
// TODO: XXX DUBIOUS XXX
// l should be a List<String> and myFiles should be a
List<FileDetails>, so contains should always return false!
if (!myFiles.contains(f)) {
{code}
This is concerning because if we have proper typing, then {{contains}} should
always return false. Are we always downloading the files and improperly caching
the results?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
