[
https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369724#comment-17369724
]
Mike Drob commented on SOLR-14660:
----------------------------------
{quote}(1) There are test classes in Solr core which are referred to by hdfs
test classes, for example org.apache.solr.util.MockCoreContainer.
Gradle does not allow defining dependencies between test artifacts of different
modules. It defines the concept of testFixtures for this purpose - it has a
built-in plugin that handles the src/testFixtures directory, builds a fixtures
jar file from all of those classes, and the fixtures have automatic
dependencies to the source classes of their defining module. Another module
(like the HDFS contrib) can define dependencies to the solr core test fixtures
like this: testImplementation(testFixtures(project(“:solr:core”)))
{quote}
I'm not worried right now about 'bloating' test-framework, but if you feel like
test fixtures are better then feel free to implement that way. I would pick
whichever one is easier to do, and we can come back to it later.
{quote}Since at this step we would like to separate HDFS only, I plan to
refactor this and similar classes for example by splitting to HdfsTestUtil and
HadoopTestUtil, and try to separate the Hadoop and HDFS code so there is no
circular dependency.
{quote}
What parts of Hadoop do we use that are not HDFS? I understand that Hadoop
refers to the umbrella project, but I was under the impression that we do not
have e.g. map reduce or yarn code in Solr, and we only using the storage bits.
Separating the two out could be a worthwhile goal anyway, but for these
purposes I think it's ok the treat Hadoop and HDFS as one thing. Please
elaborate if you disagree.
{quote}I'll need to introduce a common base class of the 2, which can be put to
either the test framework or the test fixtures of Solr Core so it can be shared
between the core tests and the HDFS tests
{quote}
Again, I think it's ok to pollute test-frameworks with this for now and we can
revisit it later.
> Migrating HDFS into a package
> -----------------------------
>
> Key: SOLR-14660
> URL: https://issues.apache.org/jira/browse/SOLR-14660
> Project: Solr
> Issue Type: Improvement
> Reporter: Ishan Chattopadhyaya
> Priority: Major
> Labels: package, packagemanager
>
> Following up on the deprecation of HDFS (SOLR-14021), we need to work on
> isolating it away from Solr core and making a package for this. This issue is
> to track the efforts for that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
