cpoerschke commented on pull request #195: URL: https://github.com/apache/solr/pull/195#issuecomment-869039643
> This one is slightly bigger than the others, but I think the median change is also lower complexity. There were a lot of thornier issues that I decided to skip over completely for now in solr-core. Wow, I admire your stamina and patience with this cleanup effort! Thank you. The sheer "Files changed 352" number made me wonder about a script to somehow split the review and tool assisted reviewing. And so I hacked up a script to help me, specifically looking for files that had _only_ removals and/or relocations of `@SuppressWarnings` and/or additions of `<Object>` or `<?>` or `<>` i.e. easily reviewed low complexity changes. On the assumption that no one else has yet started to review here I'd like to add two commits to remove 254+5 files from the scope of this pull request (i.e. defer them to Part V) leaving 93 files here to review on the github UI whilst the tests are running locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
