bitnahian opened a new pull request #202: URL: https://github.com/apache/solr/pull/202
https://issues.apache.org/jira/browse/SOLR-15376 # Description `CollectionAdminRequest.CreateTimeRoutedAlias.setMaxFutureMs` method only accepts an integer value as a parameter. The Java Integer.MAX_VALUE is `2147483647`. This value is too small to accommodate for any duration greater than ~ 25 days. # Solution Create an Overloaded method for setMaxFutureMs that accepts a Long type and change the type of instance variable `maxFutureMs` to a Long type and safely convert the original method's Integer type to a Long type in the original function. # Tests Attempted to run tests under org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java but tests are currently ignored. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
