benediktarnold opened a new pull request #212: URL: https://github.com/apache/solr/pull/212
https://issues.apache.org/jira/browse/SOLR-15531 # Description The `SignificantTermsQParserPlugin` uses the class `SparseFixedBitSet` internall that requires a length parameter >= 1. In order to fill the parameter, the result of `searcher.indexReader().maxDoc()` which is 0 for shards without any document. # Solution Before the Plugin creates the analytics collector, the proposed solution checks `maxDocs` and decides if it should return the `SignifcantTermsCollector` or a no op collector. # Tests 1. A test to check the existing behavior for collections with at least one document 2. A test to verify the error against a collection with 0 documents. # Checklist Please review the following and check all that apply: - [ x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ x] I have created a Jira issue and added the issue ID to my pull request title. - [x ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x ] I have developed this patch against the `main` branch. - [ (still running)] I have run `./gradlew check`. - [ x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
