madrob commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-882802608
> if getCurrentSchemaModificationVersion throws an exception, then its caller doesn't have to catch the exception; Is this an _is_ or _ought_ statement? In other words, are you saying that this is a problem currently? What would you expect a caller to do if there is an exception thrown? How is it different from the current case of catching SolrException? > As this change is trivial, it can be part of SOLR-15258 (ConfigSetService refactoring) Yes, that's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
