[ 
https://issues.apache.org/jira/browse/SOLR-15496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384996#comment-17384996
 ] 

ASF subversion and git services commented on SOLR-15496:
--------------------------------------------------------

Commit 27c085aa417b43df025b16ec3955d1c29613f777 in lucene-solr's branch 
refs/heads/branch_8x from Marcos Pontes
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=27c085a ]

SOLR-15496: Reuse comparator objects in contrib/ltr rescorer classes. (#228)



> LTRRescorer unnecessarily (re)creates ScoreDoc Comparator objects
> -----------------------------------------------------------------
>
>                 Key: SOLR-15496
>                 URL: https://issues.apache.org/jira/browse/SOLR-15496
>             Project: Solr
>          Issue Type: Task
>          Components: ltr
>            Reporter: Christine Poerschke
>            Priority: Minor
>              Labels: newdev
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Discovered by [~mdrob] whilst reviewing SOLR-14920 changes:
> A static instance of the comparator(s) could be created and reused.
> * 
> https://github.com/apache/solr/blob/af0455ac8366d6dba941f2b2674ed2a8245c76f9/solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java#L133-L162
> * https://github.com/apache/solr/pull/189#discussion_r657360363



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to