athrog commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-895489520
One more comment since I saw you updated the `versions.lock` file. I noticed that the s3mock project pulls in a few new versions of libs that solr uses. This seemed like a bad thing to me (in that this commit could break other parts of Solr code that use, say commons-codec 1.13 and haven't been tested with 1.15). I have a local commit that explicitly excludes those libs and doesn't negatively impact s3mock, will do some testing around that and push in a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org