Jdurham2843 commented on a change in pull request #243:
URL: https://github.com/apache/solr/pull/243#discussion_r686474438
##########
File path: solr/CHANGES.txt
##########
@@ -317,6 +317,11 @@ Other Changes
* SOLR-15385: Address many rawtypes warnings, resulting in several modified
signatures in the public API. (Mike Drob, David Smiley, Christine Poerschke)
+* SOLR-15480: Added a new putAll methods for Tuple.fields to take care of
marking EOF and EXCEPTION when those tokens are found.
+ The copy constructor (taking only fields), the merge, and the clone methods
were updated to use the new putAll method. Additionally,
+ a new copy constructor taking another Tuple object was added and it, along
with clone and merge, were refactored to handle setting
+ fieldNames and fieldLabels if necessary. (John Durham)
+
Review comment:
I think that makes sense. It shouldn't be about what was done
specifically, but about what the result of the changes are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
