thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690689552
########## File path: controllers/solrcloud_controller_tls_test.go ########## @@ -126,7 +126,6 @@ func TestMountedTLSDir(t *testing.T) { mountedDir := &solr.MountedTLSDirectory{} mountedDir.Path = "/mounted-tls-dir" instance.Spec.SolrTLS = &solr.SolrTLSOptions{MountedServerTLSDir: mountedDir, CheckPeerName: true, ClientAuth: "Need", VerifyClientHostname: true} - expectMountedTLSDirEnvVars(t, util.TLSEnvVars(instance.Spec.SolrTLS, false)) Review comment: the TLS env vars will get checked in the `expectMountedTLSDirConfigOnPodTemplate` after reconciliation, so no need to do here ... same comment for change below this too ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org