dsmiley commented on a change in pull request #264:
URL: https://github.com/apache/solr/pull/264#discussion_r694333269
##########
File path:
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java
##########
@@ -74,12 +75,12 @@ public void init(NamedList<?> args) {
args.remove("mutable");
managedSchemaResourceName = params.get(MANAGED_SCHEMA_RESOURCE_NAME,
DEFAULT_MANAGED_SCHEMA_RESOURCE_NAME);
args.remove(MANAGED_SCHEMA_RESOURCE_NAME);
- if (SCHEMA_DOT_XML.equals(managedSchemaResourceName)) {
+ if (SCHEMA_DOT_XML.equals(managedSchemaResourceName)) { // TODO Still
needed?
Review comment:
I agree; I think a user should be able to configure it to be the same if
they wish. But I would make such a change in a separate issue, and also see
that there is no problem with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
