gus-asf commented on pull request #265: URL: https://github.com/apache/solr/pull/265#issuecomment-906544658
> If the idea is to leverage the constructs in the servlet API more to our advantage, then perhaps both Tracing and Rate Limiting should be servlet Filters? > YES :) ... very much something this is meant to enable in the future. > FWIW I don't find SolrDispatchFilter _that_ bad, though there are some warts and my other PR ( #155 ) tries to tackle some. If you read the opening of my PR there, you'll see I dug deeper into some complexities like the cores==null checks that seem unnecessary. Apparently those are there due to Mikhail's realization in SOLR-10615 that init() isn't necessary complete before doFilter can be called which shocked him and me too; I'm kinda in disbelief honestly. Seems like it should have generated a ticket with Jetty at least since while the spec doesn't actually state that the call to init() must have been completed, that sure sounds like something the spec authors wouldn't have thought necessary to say... 6.2.1 Filter Lifecycle ... snip ... The container must ensure that it has instantiated a filter of the appropriate class for each filter in the list, and called its init(FilterConfig config) method. The filter may throw an exception to indicate that it cannot function properly. If the exception is of type UnavailableException, the container may examine the isPermanent attribute of the exception and may choose to retry the filter at some later time ... snip ... And this section implies that waiting is the wrong strategy anyway. Requests to a server not fully started should fail temporarily unavailable. (how well that plays with tests might be an issue that caused us to wait though). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
