cpoerschke commented on pull request #236:
URL: https://github.com/apache/solr/pull/236#issuecomment-906592633


   > > perhaps any fix would be for 9x only and then no need to consider the 
scenario of the caller having added surrounding quotes since backwards 
compatibility is not retained anyhow
   > 
   > I think we still want to back port a fix for colons at least to 8x? Maybe 
there are parts that stay 9x only, but I think this is probably something 
important to have in our release line
   
   One way for a backwards compatible or "backwards compatible friendly" change 
for the 8x release line could be via an optional flag:
   
   ```
   shortestPath(
     collection,
     from="j...@company.com",
     to="j...@company.com",
     ...
   )
   ```
   
   or
   
   ```
   shortestPath(
     collection,
     from="j...@company.com",
     to="j...@company.com",
     ...
     solr15546fix=true
   )
   ```
   
   for fixed behaviour with the option of
   
   ```
   shortestPath(
     collection,
     from="j...@company.com",
     to="j...@company.com",
     ...
     solr15546fix=false
   )
   ```
   
   for backwards compatible behaviour. So `solr15546fix` as an opt-out, 
`solr15546fix` would have to be some other name of course, and depending on 
name and whether or not it would be in 9.x also it could also be opt-in rather 
than opt-out though for this type of fix opt-out seems best.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to