dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699608834
##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -61,8 +61,9 @@ subprojects {
"Specification-Version" : project.baseVersion,
"Specification-Title" : title,
- "X-Compile-Source-JDK" :
"${project.sourceCompatibility}",
- "X-Compile-Target-JDK" :
"${project.targetCompatibility}",
+ // Evaluate these properties lazily so that the
defaults are applied properly.
+ "X-Compile-Source-JDK" : "${->
project.sourceCompatibility}",
Review comment:
I think you're familiar with it, you just don't know it. :) I recall I
head-scratched over the very same thing... It's a gstring (lazily evaluated
string) with a snippet of gradle code which happens to be a parameterless
closure. The jar plugin is actually better now and supports lazy providers...
So this could be modified entirely. I just copied the solution that worked in
Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
