HoustonPutman commented on a change in pull request #318:
URL: https://github.com/apache/solr-operator/pull/318#discussion_r699685355
##########
File path: helm/solr-operator/templates/deployment.yaml
##########
@@ -64,6 +64,10 @@ spec:
{{- if .Values.mTLS.insecureSkipVerify }}
- --tls-skip-verify-server={{ .Values.mTLS.insecureSkipVerify }}
{{- end }}
+ {{- if .Values.mTLS.watchForUpdates }}
+ - --tls-watch-cert={{ .Values.mTLS.watchForUpdates }}
Review comment:
`{{- if .Values.mTLS.watchForUpdates }}` returns false for `false`
values, so the only way for the if statement to be passed is if
`watchForUpdates` is true. Since the default value in the operator is `true`,
there's no way to set `watchForUpdates` to *false* using the helm chart.
I would probably just remove the if statement here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
