makosten opened a new pull request #288: URL: https://github.com/apache/solr/pull/288
https://issues.apache.org/jira/browse/SOLR-6910 # Description This is an implementation of distributed delete-by id-when using the CompositeId router and the route field is missing. This is requested by SOLR-6910 and referenced in SOLR-5810 and SOLR-8889. The current behavior in this circumstance is to perform the delete by id only on the shard which received the request, even if the document is on a different shard. There has been some discussion of instead implementing a strict mode, in which case the delete-by-id would fail with a message that the routing key is required, but these two approaches are not mutually exclusive. This is this "non-strict" implementation. There are use cases for this feature, such as a volatile shard key or implementing a separate indexing pipeline for deletions without consulting a database. Using delete-by-query is a workaround but is much less performant. # Solution This first approach detects this condition and forwards the request to the doDeleteByQuery method. This works, but it would be better to extract the shared code from doDeleteByQuery. I looked at this but need some advice on how to proceed. # Tests I've extended an existing test to verify the new behavior. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
