Jdurham2843 commented on a change in pull request #243: URL: https://github.com/apache/solr/pull/243#discussion_r704921916
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ########## @@ -87,10 +87,20 @@ public Tuple(String k1, Object v1, String k2, Object v2) { * @param fields map containing keys and values to be copied to this tuple */ public Tuple(Map<String, ?> fields) { - // TODO Use bulk putAll operation that will properly size the map - // https://issues.apache.org/jira/browse/SOLR-15480 - for (Map.Entry<String, ?> entry : fields.entrySet()) { - put(entry.getKey(), entry.getValue()); + putAll(fields); + } + + /** + * A copy constructor + * @param original Tuple that will be copied + */ + public Tuple(Tuple original) { + this.putAll(original.fields); + if (original.fieldNames != null) { + this.fieldNames = new ArrayList<>(original.fieldNames); + } + if (original.fieldLabels != null) { + this.fieldLabels = new HashMap<>(original.fieldLabels); Review comment: > Another edge case is collisions in the field labels, I'll add a TupleTest.writeMapTest() for that, let me know what you think and/or feel free to amend or revert. I think the the test your wrote looks good! I think it clearly illustrates usage of Tuple. I went back and updated the `TupleTest.mergeTest` to where the `fieldNames` and `fieldLabels` relate to the `fields` key to go along with the theme of having the tests mimic actual use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org