markrmiller commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r706257640
##########
File path:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
##########
@@ -179,7 +179,11 @@ public static BitSetProducer getCachedBitSetProducer(final
SolrQueryRequest requ
SolrCache<Query, BitSetProducer> parentCache =
request.getSearcher().getCache(CACHE_NAME);
// lazily retrieve from solr cache
if (parentCache != null) {
- return parentCache.computeIfAbsent(query, QueryBitSetProducer::new);
+ try {
+ return parentCache.computeIfAbsent(query, QueryBitSetProducer::new);
+ } catch (IOException e) {
+ throw new AssertionError("Can't happen");
Review comment:
Not a fan of this myself. Impls change, new impls are added, it's
declared to throw an IOException. Personally, I'd just turn it into a runtime
io exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
