TheSench opened a new pull request #296: URL: https://github.com/apache/solr/pull/296
https://issues.apache.org/jira/browse/SOLR-15626 # Description The `config-read` permission was not including the `null` collection, preventing it from being matched on endpoints like `/amin/configs?action=LIST`, as they are not associated with a specific collection. # Solution I simply updated the `config-edit` to include both `null` and `"*"` in its list of collections like the `config-edit` permission is already doing. # Tests I created a `security.json` file that gave the `config-read` permission to one user and `all` to a different one. I then tested booting up Solr with and without this change. Without it, navigating to `/amin/configs?action=LIST` results in a 403 for the user with `config-read` permissions. With the change, that user is properly allowed to access this endpoint. I did not find any unit tests related to these files. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [N/A] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
