HoustonPutman commented on pull request #302: URL: https://github.com/apache/solr-operator/pull/302#issuecomment-926208319
Ok I have refactored to use a new more kube-style way of listing repositories. I've also updated the documentation and examples. One big difference is we are no longer supporting the legacy location for the backupRepository information. The SolrCloud.withDefaults() will auto-move this information to the `backupRepositories` list. However, we lose the old location where these directories were mounted. This is not an issue, since the Solr Operator will use this new location after it's upgrade. The only issue is when the Solr Operator has upgraded, but the SolrClouds are still in a rolling-restart to update the mountPath of the legacy backupRepo. Users will have to hold off of doing any backups until the SolrClouds they are using have been fully updated. Once this is done, there should be no issues with backwards-compatibility. I have added a warning for this in the upgrade-notes for `v0.5.0`. I think it's an acceptable tradeoff to not need a lot of custom code. Also we will be able to remove the deprecated option completely in `v0.6.0` without creating an issue for existing clouds (since the deprecated option will have been moved to `backupRepositories`). I think there are a few things left to do: - [ ] Add helm chart options for the backupRepositories, update Helm documentation - [ ] Add a changelog entry. - [ ] Add assert messages in new tests. Will try to wrap this up tomorrow. And hopefully do some integration tests afterwards. Would love help with the integration tests if anyone has time for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
