epugh commented on pull request #307: URL: https://github.com/apache/solr/pull/307#issuecomment-926898957
> There are 2 issues with this PR: > > * The Ref Guide URLs used will always point to the "latest" version of the Ref Guide, so when someone is using 9.0 and the "latest" Ref Guide is 9.5, they will get redirected to the 9.5 version which may be significantly wrong for them. I brought this up in the issue and believe it's a serious limitation that needs to be accounted for. > > * In just a short spot check I noticed at least one case where the replacement Ref Guide page has been renamed in `main` branch, but this uses the branch_8x name (`detecting-languages-during-indexing` -> `language-detection`). This leads me to believe there may be several other of these so I didn't check further. I did run into the versioning issue as well, at least one file that I swore existed, `script-update-processor.adoc` is only in Solr 9, not in Solr 8. My goal on this was just to try and remove the old wiki links, and not try to solve the versioning problem. I figure once we solve the versioning issue, well, then we probably would need to make all these links smarter anyway, which would mean a pass through everywhere we reference links. As far as the links to unreleased 9 versus released 8, my workflow was to try the link, see if it redirected to a existing ref guide (I landed on a bunch of version `/6_6/` pages that way), and then if not, look in the latest Ref Guide to find something. Do we have a link checker that runs that would find these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
