dweiss commented on a change in pull request #304:
URL: https://github.com/apache/solr/pull/304#discussion_r716974876
##########
File path: gradle/testing/randomization/policies/solr-tests.policy
##########
@@ -226,4 +226,8 @@ grant {
permission java.io.FilePermission "${gradle.worker.jar}", "read";
// Allow reading from classpath JARs (resources).
permission java.io.FilePermission "${gradle.user.home}${/}-", "read";
+ // Allow reading from local Lucene development repository, if used.
+ permission java.io.FilePermission "${lucene-dev-repo.dir}${/}-", "read";
+ // Allow reading jars from mavenLocal repository
+ permission java.io.FilePermission
"${user.home}${/}.m2${/}repository${/}org${/}apache${/}lucene${/}-", "read";
Review comment:
Correct, if a property is unset, the line is ignored. To be honest, I
don't think it's a big problem even if we opened up the entire .m2 repository
for read-access... I don't need it has to be so fine-grained and I don't have a
problem with it. I'm for occam's razor - less code doing the same thing is
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
