murblanc commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r719206474
########## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ########## @@ -54,6 +54,28 @@ public static ConfigSetService createConfigSetService(CoreContainer coreContainer) { final ConfigSetService configSetService = instantiate(coreContainer); + + // bootstrap conf if provided + String confDir = System.getProperty("bootstrap_confdir"); + boolean boostrapConf = Boolean.getBoolean("bootstrap_conf"); + try { + if(confDir != null) { + Path configPath = Paths.get(confDir); + if (!Files.isDirectory(configPath)) + throw new IllegalArgumentException("bootstrap_confdir must be a directory of configuration files"); Review comment: Would be helpful in such an exception to actually put the path value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org