dweiss commented on a change in pull request #323:
URL: https://github.com/apache/solr/pull/323#discussion_r719991011



##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -38,6 +38,17 @@ versionsLock {
 
 description = 'Solr reference guide'
 
+def shouldSkipTasks = propertyOrEnvOrDefault("solr.ref-guide.skip", 
"SOLR_REF_GUIDE_SKIP", "false")
+if (shouldSkipTasks.toLowerCase().startsWith("t")) {

Review comment:
       it should really parse this as a boolean. Also, I think a proper way to 
skip ref-guide tasks would be to eliminate the dependency on the artifacts of 
that project (if the trigger is enabled), not just disable all of the project's 
tasks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to