cpoerschke commented on a change in pull request #328: URL: https://github.com/apache/solr/pull/328#discussion_r724007730
########## File path: solr/core/src/test/org/apache/solr/handler/component/UpdateLogCloudTest.java ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.component; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.LinkedList; +import java.util.List; + +import org.apache.solr.client.solrj.SolrClient; +import org.apache.solr.client.solrj.embedded.JettySolrRunner; +import org.apache.solr.client.solrj.request.CollectionAdminRequest; +import org.apache.solr.client.solrj.request.QueryRequest; +import org.apache.solr.client.solrj.request.UpdateRequest; +import org.apache.solr.cloud.AbstractDistribZkTestBase; +import org.apache.solr.cloud.SolrCloudTestCase; +import org.apache.solr.common.util.NamedList; +import org.junit.BeforeClass; +import org.junit.Test; + +public class UpdateLogCloudTest extends SolrCloudTestCase { + + private static String COLLECTION; + private static final int NUM_SHARDS = 1; + private static final int NUM_REPLICAS = 4; + + @BeforeClass + public static void setupCluster() throws Exception { + + // decide collection name ... + COLLECTION = "collection"+(1+random().nextInt(100)) ; Review comment: > Do we need this randomization? Strictly speaking it's not needed but I prefer a slightly non-deterministic name over a fully hard-coded name. And especially `collection1` for a collection name can be confusing since at a glance it might be interpreted to use the https://github.com/apache/solr/tree/main/solr/core/src/test-files/solr/collection1 configuration whereas actually as per line 49 below the collection in this test uses the https://github.com/apache/solr/tree/main/solr/core/src/test-files/solr/configsets/cloud-dynamic/conf configset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
