[ 
https://issues.apache.org/jira/browse/SOLR-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426916#comment-17426916
 ] 

Carlos Grappa commented on SOLR-15591:
--------------------------------------

Here's the  [PR|https://github.com/apache/solr/pull/340] from my fork.

I didn't know if this case merited adding new tests since it is just a change 
on the logic.

Let me know if anything else is missing!

> NullPointerException in ExternalPaths.determineSourceHome makes debugging 
> cumbersome
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-15591
>                 URL: https://issues.apache.org/jira/browse/SOLR-15591
>             Project: Solr
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Mike Drob
>            Priority: Major
>              Labels: newdev
>
> When running a debugger set to break on exceptions, some tests will throw NPE 
> in {{determineSourceHome()}}, which we dutifully catch and easily recover 
> from. We should instead check for the null condition instead of forcing the 
> debugger to stop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to