[GitHub] [solr-operator] thelabdude commented on a change in pull request #346: Ability to get a JWT token from an OIDC provider to make calls to Solr secured by the JWTAuthPlugin

[GitBox]

thelabdude commented on a change in pull request #346:
URL: https://github.com/apache/solr-operator/pull/346#discussion_r728415304



##########
File path: controllers/solrbackup_controller.go
##########
@@ -158,13 +159,14 @@ func (r *SolrBackupReconciler) 
reconcileSolrCloudBackup(ctx context.Context, bac
                return nil, collectionBackupsFinished, actionTaken, err
        }
 
-       var httpHeaders map[string]string
        if solrCloud.Spec.SolrSecurity != nil {
                basicAuthSecret := &corev1.Secret{}
                if err := r.Get(ctx, types.NamespacedName{Name: 
solrCloud.BasicAuthSecretName(), Namespace: solrCloud.Namespace}, 
basicAuthSecret); err != nil {
                        return nil, collectionBackupsFinished, actionTaken, err
                }
-               httpHeaders = map[string]string{"Authorization": 
util.BasicAuthHeader(basicAuthSecret)}
+               httpHeaders := map[string]string{"Authorization": 
util.BasicAuthHeader(basicAuthSecret)}

Review comment:
       TODO: Still need to add support for Oidc for the backup controller




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org