[
https://issues.apache.org/jira/browse/SOLR-15696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432996#comment-17432996
]
ASF subversion and git services commented on SOLR-15696:
--------------------------------------------------------
Commit 0ff42b192091be71c0072f577b95325e95e34faf in lucene-solr's branch
refs/heads/branch_8x from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0ff42b1 ]
SOLR-15696: Fix ShardBackupId parsing for backups
Incremental backups store metadata files whose names are constructed in
part on the name of individual shards. These filenames are then parsed
later on to extract the shard name and "backup ID".
The parsing in question was overly-brittle though, not accounting for
the variations that shard-splitting etc. produce in shard names. This
caused incremental backups to fail for any collection that had
previously performed a shard-split.
This commit updates the parsing logic to handle these cases more
flexibly, allowing post-shardsplit backups to now succeed.
> Incremental Backups fail following a splitshard op
> --------------------------------------------------
>
> Key: SOLR-15696
> URL: https://issues.apache.org/jira/browse/SOLR-15696
> Project: Solr
> Issue Type: Improvement
> Components: Backup/Restore
> Affects Versions: 8.9
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Labels: backups, newdev
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Filing this ticket on behalf of a reporter on the mailing list (Jordan Diehl)
> who had trouble filing it themselves. See the "Can't create solr jira bugs"
> thread for more context.
> "I have been attempting to use the incremental backup API on Solr 8.9.0, but
> while testing in our product we would occasionally get into a state where all
> subsequent backup attempts would fail. After some triage we found that it was
> happening to any collection which had undergone a shard split operation. If
> we did a backup, completed a shard split operation, then attempted another
> backup, the second backup would fail with a FileNotFound exception relating
> to the backup id of the second backup as the error message."
> *Steps to Reproduce:*
> Run the script found [here|https://paste.apache.org/o4uta] in a clean 8.9.0
> download. In essence, it (1) creates and fills a collection (2) performs a
> backup (successfully), (3) splits a shard in the collection, and (4) triggers
> another backup (which fails).
> *Expected Behavior*
> "If this operation is being blocked intentionally, then I would expect an
> informative error message explaining why it failed. Otherwise I would expect
> the backup to complete successfully."
> *Actual Behavior*
> "The backup operation fails with a NoSuchFileException."
> {code:java}
> {
> "responseHeader":{
> "status":500,
> "QTime":54},
> "failure":{
> "MYIPADDRESS:31018_solr":"org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException:Error
> from server at null: Error handling 'BACKUPCORE' action"},
> "Operation backup caused
> exception:":"java.nio.file.NoSuchFileException:java.nio.file.NoSuchFileException:
> /opt/hci/solrBackups/reproCollectionBackup/reproCollection/zk_backup_1",
> "exception":{
>
> "msg":"/opt/hci/solrBackups/reproCollectionBackup/reproCollection/zk_backup_1",
> "rspCode":-1},
> "error":{
> "metadata":[
> "error-class","org.apache.solr.common.SolrException",
> "root-error-class","org.apache.solr.common.SolrException"],
>
> "msg":"/opt/hci/solrBackups/reproCollectionBackup/reproCollection/zk_backup_1",
> "trace":"org.apache.solr.common.SolrException:
> /opt/hci/solrBackups/reproCollectionBackup/reproCollection/zk_backup_1\n\tat
> org.apache.solr.client.solrj.SolrResponse.getException(SolrResponse.java:65)\n\tat
>
> org.apache.solr.handler.admin.CollectionsHandler.invokeAction(CollectionsHandler.java:301)\n\tat
>
> org.apache.solr.handler.admin.CollectionsHandler.handleRequestBody(CollectionsHandler.java:257)\n\tat
>
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:216)\n\tat
>
> org.apache.solr.servlet.HttpSolrCall.handleAdmin(HttpSolrCall.java:836)\n\tat
> org.apache.solr.servlet.HttpSolrCall.handleAdminRequest(HttpSolrCall.java:800)\n\tat
>
> org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:545)...<snip>...",
> "code":500}}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
