[ 
https://issues.apache.org/jira/browse/SOLR-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-15697:
--------------------------------------
    Attachment: SOLR-15697.patch
        Status: Open  (was: Open)

bq. I think it's safe to just make the ErrorLogMuter also check the message 
strings of the Throwable (and it's nested throwables since we distributed code 
that frequently just wraps a remote exception and tests check for the nested 
message)

Attached patch adds this.

I think this is good to go and clean to backport for 8.11 -- which will allow 
us to completely remove SolrException.ignorePatterns (and it's associated cruft 
in SolrException.log()) for 9.0, and then we can gradually clean up and replace 
those SolrException.log() in the other sub-tasks over the life of 9.x.

> replace SolrException.ignorePatterns with something that doesn't depend on 
> SolrException.log()
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-15697
>                 URL: https://issues.apache.org/jira/browse/SOLR-15697
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-15697.patch, SOLR-15697.patch
>
>
> We should deprecated & remove the following code:
>  * {{SolrException.log()}}
>  * {{SolrException.ignorePatterns}}
>  * {{SolrTestCaseJ4.ignoreException()}}
>  * {{SolrTestCaseJ4.unIgnoreException()}}
>  * {{SolrTestCaseJ4.resetExceptionIgnores()}}
> ...and replace with something that hooks directly into logj4 Filtering



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to