gerlowskija commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-954904055
Whoa man, this is awesome. Thanks for picking this up - you took it right off my TODO list haha. I've just taken a glance so far but intend to give it a more thorough review this afternoon (or Monday at latest). One preliminary comment that I'm sure will put my foot solidly in my mouth once I actually review the code: I'm surprised to see that the scheduling functionality is exposed in the 'solrbackup' CRD as opposed to a new, separate resource type. Did you consider a separate CRD at all, and if so was there a reason you decided to do same-CRD? (When I thought of starting this work myself I assumed the backup-schedule functionality would have to be a separate CRD - so now I'm trying to recall whether that was just an assumption on my part or whether there was a particular reason behind that thought haha Maybe it was jut a conceptual misunderstanding or inflexibility on my part? In my head I've always conceptualized 'solrbackup' as being scoped to tracking the progress of a single, one-off backup. A user might be surprised that some solrbackup resources represent one-offs that will never impact the cluster again, and others represent ongoing periodic work that'll continue indefinitely.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
