HoustonPutman commented on a change in pull request #357: URL: https://github.com/apache/solr-operator/pull/357#discussion_r741128852
########## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ########## @@ -71,7 +71,7 @@ spec: description: The location to store the backup in the specified backup repository. type: string persistence: - description: Persistence is the specification on how to persist the backup data. + description: 'Persistence is the specification on how to persist the backup data. This feature has been removed as of v0.5.0. Any options specified here will not be used. TODO: Remove this field entirely in v0.6.0' Review comment: Fair enough on removing the TODO, because we might want to leave in the field anyways (for yaml back-compat). These files are auto-generated by `make manifests` after you edit anything in the `api/` package. So we can't really add yaml comments here. These descriptions are taken from the comments before the property in the struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org