[
https://issues.apache.org/jira/browse/SOLR-15590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440083#comment-17440083
]
Gus Heck commented on SOLR-15590:
---------------------------------
Updated PR, for second round of review. Removed stuff that's not meant to go in
with this change. If no major comments will look to push it in next weekend
> Start up Core Container via ServletContextListener
> --------------------------------------------------
>
> Key: SOLR-15590
> URL: https://issues.apache.org/jira/browse/SOLR-15590
> Project: Solr
> Issue Type: Improvement
> Affects Versions: main (9.0)
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Anyone who has had to work on HttpSolrCall, or SolrDispatchFilter will have
> noticed that we have a LOT going on and that it gets very convoluted. This is
> bad for maintenance, and probably also bad for performance. After reading
> for a while I suspect that the primary thing that has lead to this is that
> the only way to get a reference to CoreContainer is to be in or initialized
> in or invoked by the SolrDispatchFilter or HttpSolrCall classes.
> To isolate the startup code and not distract from the dispatch code and also
> to make it possible to later add features that don't live in
> SolrDispatchFilter and also possibly to split out some features from
> SolrDispatchFilter into servlets or separate filters, this ticket moves
> CoreContainer into a CoreService class that will provide CoreContainer and a
> few other objects like the httpclient to other components that need it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
