[
https://issues.apache.org/jira/browse/SOLR-15141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441159#comment-17441159
]
Jason Gerlowski commented on SOLR-15141:
----------------------------------------
I discussed this a bit offline with Eric Pugh. He suggested that if we had a
set of v1 API tests which made requests manually (i.e. without SolrJ), then we
could switch SolrJ over to using the v2 API without fear that v1 would be
totally uncovered. It's a good idea - though the v1 API tests might be onerous
to write if they're intended to explicitly validate much of the v1 API without
the help of our main client. But it's an avenue to consider if it seems less
costly than supporting v1 and v2 simultaneously in SolrJ.
> Investigate V2RequestSupport's role in SolrJ's V2 API support
> -------------------------------------------------------------
>
> Key: SOLR-15141
> URL: https://issues.apache.org/jira/browse/SOLR-15141
> Project: Solr
> Issue Type: Task
> Components: SolrJ, v2 API
> Affects Versions: 8.8, main (9.0)
> Reporter: Jason Gerlowski
> Priority: Minor
> Labels: V2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The V2RequestSupport interface was the original plan for building support for
> the v2 API into SolrJ's existing request objects. It relies on
> {{CollectionApiMapping.Meta}} to convert v1 request objects into instances of
> the generic V2Request class.
> This worked well as the V2 APIs were originally conceived, but has developed
> a few issues over time.
> # V2RequestSupport's reliance on the {{Meta}} mapping class means that it
> only works with jsonspec-based v2 APIs and not the annotated-POJOs that the
> community intends to use going forward for defining V2 APIs.
> # It requires users to create request objects that rely on v1 APIs and
> concepts. e.g. there is no "Collection Admin" path in v2 APIs.
> # Usage of the interface never took off. It's only currently used by
> CollectionAdminRequest. So it's somewhat abandoned already.
> We should deprecate V2RequestSupport in 8.x and plan to remove it in 9.0. In
> parallel (and in different JIRAs), we can work on adding v2 support to SolrJ
> one SolrRequest class at a time. (Classes that expose v2-compatible
> abstractions can be switched over to v2 implementations under-the-hood.
> Classes that don't (e.g. CollectionAdminRequest) can be deprecated and
> replaced by a more v2-friendly SolrRequest implementation.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
