janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r748080017



##########
File path: solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java
##########
@@ -51,9 +52,10 @@
 import static org.apache.solr.core.RequestParams.USEPARAM;
 
 /**
- *
+ * Base class for all request handlers.
  */
-public abstract class RequestHandlerBase implements SolrRequestHandler, 
SolrInfoBean, NestedRequestHandler, ApiSupport {
+public abstract class RequestHandlerBase implements

Review comment:
       @madrob How does the `ALL` permission work? If we made it the default, 
how would that be different from a handler not implementing the 
`PermissionNameProvider` interface at all? And how is that again different from 
`null`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to