[ 
https://issues.apache.org/jira/browse/SOLR-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446817#comment-17446817
 ] 

Dawid Weiss commented on SOLR-15807:
------------------------------------

I like it! I've written a similar thing, here [1], except instead of an 
autocloseable I pass a code block to the intercepting method. I like the 
autocloseable more though because you can modify local variables - smart.

[1] 
https://github.com/carrotsearch/console-tools/blob/master/testing/src/main/java/com/carrotsearch/console/testing/Logs.java#L59-L65


> Add a "LogInterceptor" helpe class that makes it easy to inspect & assert 
> expected log messages
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-15807
>                 URL: https://issues.apache.org/jira/browse/SOLR-15807
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-15807-1.patch, SOLR-15807.patch
>
>
> Following on some of the ideas started/outlined in the parent task...
> we should have an easy way for a block of test code to "intercept" and make 
> assertions about log messages from specific loggers (at specific log levels, 
> matching specific substrings/regexes) that happen as a result of some actions 
> during the test code.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to