uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-988640991
> Related question - Solr still uses Lucene's `Version` class several places. It's probably right when determining index compatibility, analysis components etc, but other places such as in Package Manager and outputing Solr's current version on startup and SolrCLI's version, it will be wrong. Do we have a JIRA already to introduce a `SolrVersion` class and use it where it makes sense? I think this should be done! Especially the `Package#getImplementationVersion()` no longer works with module system, so Solr should at some point use the same code as Lucene's `Version` class to get implementation version from its JAR file (in case module system is present): https://github.com/apache/lucene/pull/473 I will merge this now, this should be separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
