[ https://issues.apache.org/jira/browse/SOLR-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464704#comment-17464704 ]
Christine Poerschke commented on SOLR-15873: -------------------------------------------- illustrative draft pull requests: * Step 1: ** the [top commit|https://github.com/apache/solr/pull/474/commits/5f9078bca9cbfd189179eb33557f05bbf97651fc] on [https://github.com/apache/solr/pull/473] to factor out a {{ReRankRescorer}} class ** [https://github.com/apache/solr/pull/473] to deprecate the public {{LTR[Interleaving]Rescorer.scoreFeatures}} methods so that in Step 2 we can change their signature and behaviour without backwards compatibility consideration * Step 2: ** the [top commit|https://github.com/apache/solr/pull/475/commits/0f13f6234477812a174ee58f06a53ec126661846] on [https://github.com/apache/solr/pull/475] to simplify LTR[Interleaving]Rescorer code i.e. *** non-support of {{rescore(IndexSearcher searcher, TopDocs firstPassTopDocs, int topN)}} resulting in {{topN}} removal in various places resulting in the {{hitUpto >= topN}} code block's removal What do you think? > simplify LTR[Interleaving]Rescorer code > --------------------------------------- > > Key: SOLR-15873 > URL: https://issues.apache.org/jira/browse/SOLR-15873 > Project: Solr > Issue Type: Task > Components: contrib - LTR > Reporter: Christine Poerschke > Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > On the dev mailing list > [https://lists.apache.org/thread/113d1yzty5ryvyt2o9msfytldv41qpgq] thread > [~4nn4r] shared about the discovery of the > {{org.apache.solr.ltr.LTRRescorer#scoreSingleHit}} code block and how > {{hitUpto >= topN}} never arises and so if the piece of code be removed. > This ticket is about removing (or maybe not) of the code block. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org