dsmiley commented on a change in pull request #225: URL: https://github.com/apache/solr/pull/225#discussion_r775172372
########## File path: solr/core/src/java/org/apache/solr/analysis/TokenizerChain.java ########## @@ -49,7 +49,6 @@ public TokenizerChain(CustomAnalyzer customAnalyzer) { customAnalyzer.getTokenizerFactory(), customAnalyzer.getTokenFilterFactories().toArray(new TokenFilterFactory[0])); setPositionIncrementGap(customAnalyzer.getPositionIncrementGap(null)); - setVersion(customAnalyzer.getVersion()); Review comment: I see that you removed the call to setVersion but otherwise didn't touch a thing. Maybe we should output a warning if you set the version (no longer supported)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org