[ https://issues.apache.org/jira/browse/SOLR-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469525#comment-17469525 ]
Joel Bernstein commented on SOLR-15890: --------------------------------------- Hey Michael! Happy to so the SQL panel make it in. I'm not sure I'm following comment. "stmt limit 2" should be ignored by the patch I believe? And "stmt limit" would only be valid if it was followed by a number I believe. The second version of the committed handles this: "stmt limit 2" > Add a limit to the Admin SQL panel if one is not included in the stmt > --------------------------------------------------------------------- > > Key: SOLR-15890 > URL: https://issues.apache.org/jira/browse/SOLR-15890 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Joel Bernstein > Assignee: Joel Bernstein > Priority: Major > Fix For: main (9.0) > > Attachments: SOLR-15890.patch > > > Solr's basic select will return all results if a limit is not added to the > SQL query. Unlimited SQL queries are not ideal from the admin SQL screen. > It's safer to append a LIMIT clause to every SQL query that does not include > a LIMIT, rather than surprise the user with a massive result set. > Users can override the LIMIT by adding a LIMIT clause to their SQL statement. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org