thelabdude edited a comment on pull request #472: URL: https://github.com/apache/solr/pull/472#issuecomment-1006043063
@janhoy ... I think the semver code `com.github.zafarkhaja.semver` is not Locale aware: ``` org.apache.solr.util.TestSolrVersion > testVersionComponents FAILED org.junit.ComparisonFailure: expected:<[9.0.1]-rc1> but was:<[৯.০.১]-rc1> at __randomizedtesting.SeedInfo.seed([EBA979F6BCADAB5F:593FBB0BE14D10A9]:0) at org.junit.Assert.assertEquals(Assert.java:117) at org.junit.Assert.assertEquals(Assert.java:146) at org.apache.solr.util.TestSolrVersion.testVersionComponents(TestSolrVersion.java:31) ``` Specifically, NormalVersion needs to use a Locale here: ``` public String toString() { return String.format("%d.%d.%d", major, minor, patch); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org